[dpdk-dev] [v3 2/3] LPM config file read option.

[Stephen Hemminger]

On Sat,  4 Mar 2017 12:44:18 -0800
Ravi Kerur <rkerur at gmail.com> wrote:

> +/* Bypass comment and empty lines */
> +static inline int
> +is_bypass_line(char *buff)
> +{
> +	int i = 0;
> +
> +	/* comment line */
> +	if (buff[0] == COMMENT_LEAD_CHAR)
> +		return 1;
> +	/* empty line */
> +	while (buff[i] != '\0') {
> +		if (!isspace(buff[i]))
> +			return 0;
> +		i++;
> +	}
> +	return 1;
> +}

This is not performance crtitical should not be inline.
The argument is never modified and therefore should be "const char *buff"