[dpdk-dev] [PATCH 00/61] net/qede/base: qede PMD enhancements

Mody, Rasesh Rasesh.Mody at cavium.com
Sat Mar 18 08:18:09 CET 2017


> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> Sent: Friday, March 03, 2017 2:25 AM
> 
> On 2/27/2017 7:56 AM, Rasesh Mody wrote:
> > Hi,
> >
> > This patch set adds support for new firmware 8.18.9.0, new features
> > and bug fixes.
> 
> This looks like depends other qede driver patchset [1], can you please
> confirm? If so, it helps to mention from it here.

Yes, this patch set depended on [1]. Note added in v2 submission.

> 
> Also I am getting following build errors [2].

A part of if..else got in into our final submission unintentionally, sorry about that. 

[2] addressed in v2 submission.

> 
> And there are some checkpatch and check-git-log.sh [3] errors.

[3] addressed in v2 submission.

Thanks!
-Rasesh
> 
> Thanks,
> ferruh
> 
> [1]
> http://dpdk.org/dev/patchwork/patch/20816/ [patchset with 21 patches]
> 
> 
> 
> [2]
> .../drivers/net/qede/base/ecore_dev.c:1703:4: error: use of undeclared
> identifier 'ECORE_E5_MISSING_CODE'
>                         ECORE_E5_MISSING_CODE;
>                         ^
> 1 error generated.
> make[7]: *** [base/ecore_dev.o] Error 1
> make[7]: *** Waiting for unfinished jobs....
> .../drivers/net/qede/qede_rxtx.c:1202:21: error: variable 'pad' is uninitialized
> when used here [-Werror,-Wuninitialized]
>                 rx_mb->data_off = pad + RTE_PKTMBUF_HEADROOM;
>                                   ^~~
> .../drivers/net/qede/qede_rxtx.c:997:14: note: initialize the variable 'pad' to
> silence this warning
>         uint16_t pad;
>                     ^
>                      = 0
> 1 error generated.
> 
> .../drivers/net/qede/qede_fdir.c: In function 'qede_config_cmn_fdir_filter':
> .../drivers/net/qede/qede_fdir.c:126:44: error: format '%lx' expects
> argument of type 'long unsigned int', but argument 4 has type 'uint64_t {aka
> long long unsigned int}' [-Werror=format=]
>   snprintf(mz_name, sizeof(mz_name) - 1, "%lx", rte_get_timer_cycles());
> 
> 
> 
> [3]
> Wrong headline format:
>         send FW version driver state to MFW
>         net/qede/base: decrease MAX_HWFNS_PER_DEVICE from 4 to 2
>         net/qede/base: add a printout of the FW, MFW and MBI versions
>         net/qede/base: set the drv_type before sending load request Wrong
> headline prefix:
>         send FW version driver state to MFW
>         drivers/net/qede: upgrade the FW to 8.18.9.0 Wrong headline
> uppercase:
>         net/qede/base: L2 handler changes
>         net/qede/base: Add support to set max values of soft resoruces Wrong
> headline lowercase:
>         net/qede/base: use default mtu from shared memory
>         net/qede/base: update MFW when default mtu is changed
>         net/qede/base: add non-l2 dcbx tlv application support
>         net/qede/base: allow PMD to control vport-id and rss-eng-id Headline
> too long:
>         net/qede/base: remove attribute field from update current config
>         net/qede/base: add support to read personality via MFW commands
>         net/qede/base: allow only trusted VFs to be promisc/multi-promisc
>         net/qede/base: add a printout of the FW, MFW and MBI versions
>         net/qede/base: update bulletin board with link state during init
>         net/qede/base: Add support to set max values of soft resoruces
>         net/qede/base: add multi-Txq support on same queue-zone for VFs
>         net/qede/base: fix race cond between MFW attentions and PF stop
> Missing 'Fixes' tag:
>         net/qede/base: fix to set pointers to NULL after freeing
>         net/qede/base: fix race cond between MFW attentions and PF stop
> 
> 
> 
> >
> > Please apply to dpdk-net-next for 17.05 release.
> >
> > Thanks!
> > Rasesh
> >
> > Harish Patil (3):
> >   net/qede/base: add support for arfs mode
> >   net/qede: add ntuple and flow director filter support
> >   net/qede: add LRO/TSO offloads support
> >
> > Rasesh Mody (58):
> >   net/qede/base: return an initialized return value
> >   send FW version driver state to MFW
> >   net/qede/base: mask Rx buffer attention bits
> >   net/qede/base: print various indication on Tx-timeouts
> >   net/qede/base: utilize FW 8.18.9.0
> >   drivers/net/qede: upgrade the FW to 8.18.9.0
> >   net/qede/base: decrease MAX_HWFNS_PER_DEVICE from 4 to 2
> >   net/qede/base: move mask constants defining NIC type
> >   net/qede/base: remove attribute field from update current config
> >   net/qede/base: add nvram options
> >   net/qede/base: add comment
> >   net/qede/base: use default mtu from shared memory
> >   net/qede/base: change queue/sb-id from 8 bit to 16 bit
> >   net/qede/base: update MFW when default mtu is changed
> >   net/qede/base: prevent device init failure
> >   net/qede/base: add support to read personality via MFW commands
> >   net/qede/base: allow probe to succeed with minor HW-issues
> >   net/qede/base: remove unneeded step in HW init
> >   net/qede/base: allow only trusted VFs to be promisc/multi-promisc
> >   net/qede/base: qm initialization revamp
> >   net/qede/base: add a printout of the FW, MFW and MBI versions
> >   net/qede/base: check active VF queues before stopping
> >   net/qede/base: set the drv_type before sending load request
> >   net/qede/base: prevent driver laod with invalid resources
> >   net/qede/base: add interfaces for MFW TLV request processing
> >   net/qede/base: fix to set pointers to NULL after freeing
> >   net/qede/base: L2 handler changes
> >   net/qede/base: add support for handling TLV request from MFW
> >   net/qede/base: optimize cache-line access
> >   net/qede/base: infrastructure changes for VF tunnelling
> >   net/qede/base: revise tunnel APIs/structs
> >   net/qede/base: add tunnelling support for VFs
> >   net/qede/base: formatting changes
> >   net/qede/base: prevent transmitter stuck condition
> >   net/qede/base: add mask/shift defines for resource command
> >   net/qede/base: add API for using MFW resource lock
> >   net/qede/base: remove clock slowdown option
> >   net/qede/base: add new image types
> >   net/qede/base: use L2-handles for RSS configuration
> >   net/qede/base: change valloc to vzalloc
> >   net/qede/base: add support for previous driver unload
> >   net/qede/base: add non-l2 dcbx tlv application support
> >   net/qede/base: update bulletin board with link state during init
> >   net/qede/base: add coalescing support for VFs
> >   net/qede/base: add macro got resource value message
> >   net/qede/base: add mailbox for resource allocation
> >   net/qede/base: add macro for unsupported command
> >   net/qede/base: Add support to set max values of soft resoruces
> >   net/qede/base: add return code check
> >   net/qede/base: zero out MFW mailbox data
> >   net/qede/base: move code bits
> >   net/qede/base: add PF parameter
> >   net/qede/base: allow PMD to control vport-id and rss-eng-id
> >   net/qede/base: add udp ports in bulletin board message
> >   net/qede/base: prevent DMAE transactions during recovery
> >   net/qede/base: add multi-Txq support on same queue-zone for VFs
> >   net/qede/base: fix race cond between MFW attentions and PF stop
> >   net/qede/base: semantic changes
> 
> <...>


More information about the dev mailing list