[dpdk-dev] [PATCH v2 00/46] LiquidIO PMD

Ferruh Yigit ferruh.yigit at intel.com
Tue Mar 21 13:38:18 CET 2017


On 3/2/2017 11:32 AM, Shijith Thotton wrote:
> The patch series provides initial version of virtual function poll mode
> driver for Cavium LiquidIO II server adapters. This version adds support
> for LiquidIO II CN23XX 210SV adapters.
> 
> Patch series includes driver documentation doc/guides/nics/liquidio.rst
> and list of supported features doc/guides/nics/features/liquidio.ini.
> Updated release notes to notify the addition of new PMD.
> 
> v2 changes:
> * Restructured patches as suggested by Ferruh.
>  - http://dpdk.org/ml/archives/dev/2017-February/058186.html
> * Addressed review comments on driver from Ferruh.
>  - http://dpdk.org/ml/archives/dev/2017-February/058188.html
>  - http://dpdk.org/ml/archives/dev/2017-February/058194.html
> * Modified commit logs as suggested by Ferruh.
>  - http://dpdk.org/ml/archives/dev/2017-February/058189.html
>  - http://dpdk.org/ml/archives/dev/2017-February/058190.html
>  - http://dpdk.org/ml/archives/dev/2017-February/058193.html
> * Made changes to documentation as per review comments from John.
>  - http://dpdk.org/ml/archives/dev/2017-February/058206.html
> * Fixed FreeBSD build failure.
>  - http://dpdk.org/ml/archives/test-report/2017-February/011272.html
> * Updated driver documentation:
>  - Added CN2360 under supported LiquidIO adapters.
>  - Added CRC strip under limitations.
> 
> Shijith Thotton (46):
>   config: add liquidio PMD skeleton
>   net/liquidio/base: hardware register definitions
>   net/liquidio: definitions for log
>   net/liquidio: liquidio VF PMD driver registration
>   net/liquidio/base: macros to read and write register
>   net/liquidio: liquidio device init
>   net/liquidio: add API to disable IO queues
>   net/liquidio: add API to setup IO queue registers
>   net/liquidio: add mbox APIs for PF VF communication
>   net/liquidio: add API to setup mbox registers
>   net/liquidio: add API for PF VF handshake
>   net/liquidio: add API for VF FLR
>   net/liquidio: add APIs to allocate and free IQ
>   net/liquidio: add API to setup IQ
>   net/liquidio: add APIs to allocate and free SC buffer pool
>   net/liquidio: add APIs to allocate and free soft command
>   net/liquidio: add APIs for response list
>   net/liquidio: add API to send packet to device
>   net/liquidio: add API to configure device
>   net/liquidio: add API to setup Rx queue
>   net/liquidio: initialize Rx queue
>   net/liquidio: add Rx data path
>   net/liquidio: add API to release Rx queue
>   net/liquidio: add API to setup Tx queue
>   net/liquidio: add APIs for SG list
>   net/liquidio: add APIs to enable and disable IO queues
>   net/liquidio: add Tx data path for single segment
>   net/liquidio: add Tx data path for multiple segments
>   net/liquidio: add API to flush IQ
>   net/liquidio: add API to release Tx queue
>   net/liquidio: add APIs to start device and update link
>   net/liquidio: add APIs to alloc and send control command
>   net/liquidio: add API to control Rx
>   net/liquidio: add RSS support
>   net/liquidio: add API to get device info
>   net/liquidio: add API to set MTU
>   net/liquidio: add APIs to enable and disable multicast
>   net/liquidio: add APIs to set link up and down
>   net/liquidio: add API to configure UDP tunnel port
>   net/liquidio: add support for Rx stats
>   net/liquidio: add support for Tx stats
>   net/liquidio: add APIs for hardware stats
>   net/liquidio: add API to stop device
>   net/liquidio: add API to close device
>   net/liquidio: add API to add and remove VLAN port
>   doc: add doc for liquidio

Hi Shijith,

Overall patch looks good to me, I comment on a few issues.
I think PMD is ready to merge after mentioned issues addressed.

And can you also send a web page patch to list PMD in DPDK supported
NICs web page:
http://dpdk.org/doc/nics
(web repo: http://dpdk.org/browse/tools/dpdk-web/)

Thanks,
ferruh



More information about the dev mailing list