[dpdk-dev] [PATCH v3 08/14] ring: allow enqueue fns to return free space value

[Bruce Richardson]

On Tue, Mar 28, 2017 at 09:12:39AM +0200, Thomas Monjalon wrote:
> 2017-03-24 17:10, Bruce Richardson:
> > Add an extra parameter to the ring enqueue burst/bulk functions so that
> > those functions can optionally return the amount of free space in the
> > ring. This information can be used by applications in a number of ways,
> > for instance, with single-producer queues, it provides a max
> > enqueue size which is guaranteed to work. It can also be used to
> > implement watermark functionality in apps, replacing the older
> > functionality with a more flexible version, which enables apps to
> > implement multiple watermark thresholds, rather than just one.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> > Acked-by: Olivier Matz <olivier.matz at 6wind.com>
> 
> 
> There is a an error with this patch and crypto drivers:
> 
> 
> drivers/crypto/kasumi/rte_kasumi_pmd.c:362:32: fatal error:
> too few arguments to function call, expected 4, have 3
>                                 (void **)ops, processed_ops);
>                                                            ^
> rte_ring.h:1018:1: note: 'rte_ring_enqueue_burst' declared here
> 
> 
> drivers/crypto/snow3g/rte_snow3g_pmd.c:366:31: fatal error:
> too few arguments to function call, expected 4, have 3
>                         (void **)ops, processed_ops);
>                                                    ^
> rte_ring.h:1018:1: note: 'rte_ring_enqueue_burst' declared here
> 
Yes, I'm still working through this patchset with crypto drivers enabled
myself. Patch 9 also has issues with some of the other drivers - though
I don't have this kasumi one enabled on my system myself. I'll need to
do a v4, hopefully today. Sorry for not flagging this sooner, I didn't
know you were going to try again to apply the set, so I thought I had
more time to report the results of testing with the crypto drivers.

/Bruce