[dpdk-dev] [PATCH v5 6/7] net/ark: Packet RX support initial version

Ferruh Yigit ferruh.yigit at intel.com
Tue Mar 28 16:36:02 CEST 2017


On 3/23/2017 11:01 PM, Ed Czeck wrote:
> * Core RX packet moving functions
> 
> Signed-off-by: Ed Czeck <ed.czeck at atomicrules.com>

<...>

> +/* TODO  pick a better function name */

Is it possible to do now :) Thanks.

> +static int
> +eth_ark_rx_hw_setup(struct rte_eth_dev *dev,
> +		    struct ark_rx_queue *queue,
> +		    uint16_t rx_queue_id __rte_unused, uint16_t rx_queue_idx)
> +{

<...>

> +
> +/* Only used in debug */
> +static void
> +dump_mbuf_data(struct rte_mbuf *mbuf, uint16_t lo, uint16_t hi)
> +{

There is already a rte_pktmbuf_dump(), does it works for you?

<...>

> +/* Forward declarations */
> +struct rte_mbuf;
> +struct rte_mempool;
> +struct rte_eth_dev;
> +struct rte_eth_stats;
> +struct rte_eth_rxconf;

Same comment with Tx patch, these structs can be removed by including
proper dpdk headers.


More information about the dev mailing list