[dpdk-dev] [PATCH v3 3/6] cfgfile: add support for configurable comment character

[Legacy, Allain]

> -----Original Message-----
> From: Dumitrescu, Cristian [mailto:cristian.dumitrescu at intel.com]
> Sent: Wednesday, March 29, 2017 5:23 AM
> >
> > +/** Configuration file operation optional arguments */ struct
> > +rte_cfgfile_parameters {
> > +	char comment_character;
> > +	/**< Config file comment character; one of '!', '#', '%', ';', '@'
> > +*/
> 
> I think this comment should be placed above the structure field definition
> (preferable) or on the same line, but not below.

Ok.  I will relocate it in v4 to be above.  The /**< */ construct allows for putting comments on the following line. 

> >  /**
> > + * Open config file with specified optional parameters.  Use @see
> > + * rte_cfgfile_init_parameters to setup the default parameters.
> > + *
> 
> Please update this comment, as there is no rte_cfgfile_init() function
> anymore.


Ok.  Will do.