[dpdk-dev] [PATCH v6 12/21] event/sw: add start stop and close functions

Van Haaren, Harry harry.van.haaren at intel.com
Thu Mar 30 10:49:58 CEST 2017


> From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> Sent: Thursday, March 30, 2017 9:24 AM
> To: Van Haaren, Harry <harry.van.haaren at intel.com>
> Cc: dev at dpdk.org; Richardson, Bruce <bruce.richardson at intel.com>
> Subject: Re: [PATCH v6 12/21] event/sw: add start stop and close functions

<snip>

> >  static int
> > +sw_start(struct rte_eventdev *dev)
> > +{
> > +	unsigned int i, j;
> > +	struct sw_evdev *sw = sw_pmd_priv(dev);
> > +	/* check all ports are set up */
> > +	for (i = 0; i < sw->port_count; i++)
> > +		if (sw->ports[i].rx_worker_ring == NULL) {
> > +			SW_LOG_ERR("%s %d: port %d not configured\n",
> > +			       __func__, __LINE__, i);
> 
> Remove __func__ and __LINE_ as SW_LOG_ERR macro has it already.
> Check the same issue in other places.

Good one, done and checked for all patches, will be fixed in v7.


More information about the dev mailing list