[dpdk-dev] [PATCH v2 3/3] test: add ZUC test cases for QAT

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Thu Mar 30 23:29:18 CEST 2017


Hi Arek,

> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, March 29, 2017 2:04 PM
> To: dev at dpdk.org
> Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K;
> Kusztal, ArkadiuszX
> Subject: [PATCH v2 3/3] test: add ZUC test cases for QAT
> 
> This patch adds ZUC EEA3/EIA3 test cases for QAT crypto
> test suite and consolidate ZUC test vectors into one header file.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal at intel.com>

> diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c
> index a8f3ae5..7507878 100644
> --- a/test/test/test_cryptodev.c
> +++ b/test/test/test_cryptodev.c

...

>  static int
> +test_zuc_cipher_auth(const struct wireless_test_data *tdata)
> +{
> +	struct crypto_testsuite_params *ts_params = &testsuite_params;
> +	struct crypto_unittest_params *ut_params = &unittest_params;
> +
> +	int retval;
> +
> +	uint8_t *plaintext, *ciphertext;
> +	unsigned int plaintext_pad_len;
> +	unsigned int plaintext_len;

This test (and the encryption and auth only tests) will fail if using a QAT device
without ZUC support.

I suggest to check the capabilities of the device to see if it supports ZUC
and if it doesn't, return -ENOTSUP.

Also, I would move the vectors from one file to another in another patch.

Thanks,
Pablo


More information about the dev mailing list