[dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to add many MAC addrs

Wu, Jingjing jingjing.wu at intel.com
Mon May 8 08:17:40 CEST 2017



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wu, Jingjing
> Sent: Monday, May 8, 2017 9:02 AM
> To: Thomas Monjalon <thomas at monjalon.net>; Dai, Wei <wei.dai at intel.com>
> Cc: dev at dpdk.org; Lu, Wenzhuo <wenzhuo.lu at intel.com>;
> harish.patil at cavium.com; rasesh.mody at cavium.com;
> stephen.hurd at broadcom.com; ajit.khaparde at broadcom.com; Zhang, Helin
> <helin.zhang at intel.com>; Ananyev, Konstantin
> <konstantin.ananyev at intel.com>; Chen, Jing D <jing.d.chen at intel.com>;
> adrien.mazarguil at 6wind.com; nelio.laranjeiro at 6wind.com; Richardson, Bruce
> <bruce.richardson at intel.com>; yuanhan.liu at linux.intel.com;
> maxime.coquelin at redhat.com; shepard.siegel at atomicrules.com;
> ed.czeck at atomicrules.com; john.miller at atomicrules.com
> Subject: Re: [dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to add
> many MAC addrs
> 
> 
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > Sent: Friday, May 5, 2017 10:24 PM
> > To: Dai, Wei <wei.dai at intel.com>
> > Cc: dev at dpdk.org; Lu, Wenzhuo <wenzhuo.lu at intel.com>;
> > harish.patil at cavium.com; rasesh.mody at cavium.com;
> > stephen.hurd at broadcom.com; ajit.khaparde at broadcom.com; Zhang, Helin
> > <helin.zhang at intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>;
> > Chen, Jing D <jing.d.chen at intel.com>; adrien.mazarguil at 6wind.com;
> > nelio.laranjeiro at 6wind.com; Richardson, Bruce
> > <bruce.richardson at intel.com>; yuanhan.liu at linux.intel.com;
> > maxime.coquelin at redhat.com; shepard.siegel at atomicrules.com;
> > ed.czeck at atomicrules.com; john.miller at atomicrules.com
> > Subject: Re: [dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to
> > add many MAC addrs
> >
> > 05/05/2017 02:40, Wei Dai:
> > > This patch is added to introduce a testpmd command which is used to
> > > add more than one MAC addresses one time.
> > > This command can simplify the test for the change where the type of
> > > return value of adding MAC address.
> > > Normally a MAC address may fails to be added only after many MAC
> > > addresses have been added.
> > > Without this command, a tester may only trigger failed MAC address
> > > by running many times of testpmd command 'mac_addr add' .
> > >
> > > Signed-off-by: Wei Dai <wei.dai at intel.com>
> > > ---
> > >  app/test-pmd/cmdline.c | 55
> > > ++++++++++++++++++++++++++++++++++++++++++++++++++
> > >  1 file changed, 55 insertions(+)
> >
> > This patch has not been reviewed.
> > It is not a fix and I am not sure it is needed.
> 
> The same doubt, what is this relationship with your fix in Patch 1/3?
> 
If it is only for testing for special case, and it can be done through
calling 'mac_addr add' by multi times. I'd like to Nack it.

Thanks
Jingjing



More information about the dev mailing list