[dpdk-dev] [PATCH v3 1/6] net/enic: flow API skeleton

Ferruh Yigit ferruh.yigit at intel.com
Wed May 17 13:12:33 CEST 2017


On 5/17/2017 4:03 AM, John Daley wrote:
> Stub callbacks for the generic flow API and a new FLOW debug define.
> 
> Signed-off-by: John Daley <johndale at cisco.com>
> Reviewed-by: Nelson Escobar <neescoba at cisco.com>

<...>

> diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
> index 8e16a71b7..4e8a0d9e0 100644
> --- a/drivers/net/enic/enic_ethdev.c
> +++ b/drivers/net/enic/enic_ethdev.c
> @@ -116,13 +116,28 @@ enicpmd_dev_filter_ctrl(struct rte_eth_dev *dev,
>  		     enum rte_filter_op filter_op,
>  		     void *arg)
>  {
> -	int ret = -EINVAL;
> +	int ret = 0;
> +
> +	ENICPMD_FUNC_TRACE();
>  
> -	if (RTE_ETH_FILTER_FDIR == filter_type)
> +	if (dev == NULL)
> +		return -EINVAL;

dev can't be NULL here if it is only called via filter_ctrl eth_dev_ops

<...>

> diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c
> new file mode 100644
> index 000000000..d25390f8a
> --- /dev/null
> +++ b/drivers/net/enic/enic_flow.c
> @@ -0,0 +1,154 @@
> +/*
> + * Copyright 2008-2017 Cisco Systems, Inc.  All rights reserved.
> + * Copyright 2007 Nuova Systems, Inc.  All rights reserved.
> + *
> + * Copyright (c) 2017, Cisco Systems, Inc.
> + * All rights reserved.

Is this file header correct, dates and "Nuova Systems" and double Cisco
copyright.

As a side note, there is also another LICENSE file under net/enic folder

<...>


More information about the dev mailing list