[dpdk-dev] [PATCH 1/3] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000

[Lu, Wenzhuo]

Hi Michal,

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pattan, Reshma
> Sent: Tuesday, May 23, 2017 12:35 AM
> To: Jastrzebski, MichalX K; dev at dpdk.org
> Cc: Jain, Deepak K; Van Haaren, Harry; Azarewicz, PiotrX T
> Subject: Re: [dpdk-dev] [PATCH 1/3] drivers/net: add support for IF-MIB and
> EtherLike-MIB for e1000
> 
> Hi,
> 
> Can you add the description to the commit message, describing what has
> been done.
> 
> General doubt I have , I see all IF-MIB and Ether-Like-MIB attributes are
> added as Xstats.
> But most of  IF-MIB attributes are not stats, instead they are information
> about the interface/port.
> So I guess such attributes should be displayed using separate method?
> Everything being displayed as xstats might not be correct.
The same question as Reshma. Seems most of the added parameters (if not all) are not stats.