[dpdk-dev] [PATCH 1/6] net/vmxnet3: retain counters on restart

Nachi Prachanda nprachan at Brocade.com
Thu May 25 20:31:16 CEST 2017


> From: Shrikrishna Khare [mailto:skhare at shri-linux.eng.vmware.com]
> Sent: Wednesday, May 24, 2017 2:10 PM
> 
> On Fri, 19 May 2017, Charles (Chas) Williams wrote:
> 
> > From: Nachiketa Prachanda <nprachan at brocade.com>
> >
> > Most nics like virtio, igb/ixgbe etc. don't reset counters on
> > dev_start and arguably this helps in monitoring the counters across a
> > longer time span with multiple device start/stops.
> > vmxnet3 behavior is opposite to that and counters are reset by the
> > host side implementation each time the device is restarted.
> >
> > Change the driver to save the counters in its private context before
> > it is reset by writing CMD_ACTIVATE to REG_CMD.
> >
> > Signed-off-by: Nachiketa Prachanda <nprachan at brocade.com>
> 
> This won't be able to deal with vMotion or suspend/resume?

Correct - this can't deal with the VM suspend/resume unless hypervisor maintains the counter. But this patch doesn't make that behavior any worse than what it was before.



More information about the dev mailing list