[dpdk-dev] [PATCH 1/8] net/qede: fix to disable per-VF Tx switching feature

[Patil, Harish]

-----Original Message-----
From: Thomas Monjalon <thomas at monjalon.net>
Date: Tuesday, November 7, 2017 at 5:53 PM
To: "Mody, Rasesh" <Rasesh.Mody at cavium.com>
Cc: "dev at dpdk.org" <dev at dpdk.org>, Harish Patil <Harish.Patil at cavium.com>,
"ferruh.yigit at intel.com" <ferruh.yigit at intel.com>, Dept-Eng DPDK Dev
<Dept-EngDPDKDev at cavium.com>
Subject: Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to disable per-VF Tx
switching feature

>Hi,
>
>07/11/2017 09:34, Rasesh Mody:
>> From: Harish Patil <harish.patil at cavium.com>
>> 
>> Provide a knob to control per-VF Tx switching feature by adding a config
>> option, CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH. By default, it will be kept
>> in disabled state for better performance with small sized frames.
>> 
>> Fixes: 2ea6f76aff40 ("qede: add core driver")
>> Cc: stable at dpdk.org
>> 
>> Signed-off-by: Harish Patil <harish.patil at cavium.com>
>> ---
>>  config/common_base             |    1 +
>>  drivers/net/qede/qede_ethdev.c |    9 ++++++++-
>>  2 files changed, 9 insertions(+), 1 deletion(-)
>> 
>> --- a/config/common_base
>> +++ b/config/common_base
>> +CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n
>
>We should remove all compile-time options because they cannot be used
>when DPDK is pre-packaged.
>That's why the rule is "NO NEW COMPILE TIME OPTION".
>
>After discussion with Ferruh, this patch is accepted as a hotfix.
>But this option is expected to be removed quickly.
>I've sent a patch to remove this option in 18.02:
>	http://dpdk.org/ml/archives/dev/2017-November/081488.html
>It gives you some time to supersede my patch by introducing a
>run-time driver option.
>
>Thanks

Hi Thomas,
Sure, thanks, we will address before 18.02-rc1.
Do you have any example on how to add a run-time driver option?
Does it mean to introduce some change in ethdev?
Thanks.

>