[dpdk-dev] [RFC 0/9] add new avf PMD

Ferruh Yigit ferruh.yigit at intel.com
Wed Nov 22 00:58:33 CET 2017


On 10/20/2017 1:26 AM, Jingjing Wu wrote:
> Adaptive Virtual Function (AVF) Driver is VF driver which supports
> for all future Intel devices without requiring a VM update.
> It promises the basic high speed connectivity. And since this happens
> to be an adaptive VF driver, every new drop of the VF driver would
> add more and more advanced features that can be turned on in the VM
> if the underlying HW device supports those advanced features. Most
> importantly in a device agnostic way without ever compromising on the
> base functionality. All the AVF's interface need to follow AVF spec,
> and AVF compliant interface is supported start from the
> Intel® Ethernet Controller 710 Series.

This looks like a good idea.

Still there will be device specific drivers, right?
AVF will cover only basic features of all future Intel NICs.

> 
> This patch set adds AVF PMD supporting.
>  - Device initialization 
>  - Queue setup and Device start
>  - Basic Rx and Tx.
>  - MAC address offload feature
>  - Vlan offload feature
>  - RSS offload feature
> 
> Which need to be done in later version
>  - Vectored Rx and Tx func
>  - Rx interrupt support
>  - Statistics query
>  - performance tuning
> 
> Jingjing Wu (9):
>   net/avf/base: add base code for avf PMD
>   net/avf: initilization of avf PMD
>   net/avf: enable queue and device
>   net/avf: enable basic Rx Tx func
>   net/avf: enable link status update
>   net/avf: enable ops for MAC VLAN offload
>   net/avf: enable ops for rss setting
>   net/avf: enable ops to check queue info and status
>   net/i40e: support AVF basic interface

Overall comment to whole patchset:

- Missing some documentation:
  Driver documentation, with describing config options as well
  .ini file, please update it per patch that add feature
  release notes update to announce new PMD

- There are some checkpatch warnings even except base files

- Commit logs and patch titles missing details and doesn't cover all
modifications in the patch.

<...>


More information about the dev mailing list