[dpdk-dev] [PATCH 01/39] examples/l2fwd: convert to new ethdev offloads API

Andrew Rybchenko arybchenko at solarflare.com
Fri Nov 24 16:00:48 CET 2017


On 11/23/2017 03:14 PM, Shahaf Shuler wrote:
> Ethdev offloads API has changed since:
>
> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")
>
> This commit support the new API.
>
> Signed-off-by: Shahaf Shuler <shahafs at mellanox.com>
> ---
>   examples/l2fwd/main.c | 38 ++++++++++++++++++++++++++++++--------
>   1 file changed, 30 insertions(+), 8 deletions(-)
>
> diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c
> index e89e2e1bf..a1e378be6 100644
> --- a/examples/l2fwd/main.c
> +++ b/examples/l2fwd/main.c
> @@ -110,14 +110,11 @@ struct lcore_queue_conf lcore_queue_conf[RTE_MAX_LCORE];
>   
>   static struct rte_eth_dev_tx_buffer *tx_buffer[RTE_MAX_ETHPORTS];
>   
> -static const struct rte_eth_conf port_conf = {
> +static struct rte_eth_conf port_conf = {
>   	.rxmode = {
>   		.split_hdr_size = 0,
> -		.header_split   = 0, /**< Header Split disabled */
> -		.hw_ip_checksum = 0, /**< IP checksum offload disabled */
> -		.hw_vlan_filter = 0, /**< VLAN filtering disabled */
> -		.jumbo_frame    = 0, /**< Jumbo Frame Support disabled */
> -		.hw_strip_crc   = 1, /**< CRC stripped by hardware */
> +		.ignore_offload_bitfield = 1,
> +		.offloads = DEV_RX_OFFLOAD_CRC_STRIP,

It is not directly related to the patch.
May be I miss something, but it looks like there is no way to say that
"I always strip CRC and cannot preserve it".

>   	},
>   	.txmode = {
>   		.mq_mode = ETH_MQ_TX_NONE,
> @@ -649,6 +646,9 @@ main(int argc, char **argv)
>   
>   	/* Initialise each port */
>   	for (portid = 0; portid < nb_ports; portid++) {
> +		struct rte_eth_rxconf rxq_conf;
> +		struct rte_eth_txconf txq_conf;
> +
>   		/* skip ports that are not enabled */
>   		if ((l2fwd_enabled_port_mask & (1 << portid)) == 0) {
>   			printf("Skipping disabled port %u\n", portid);
> @@ -658,6 +658,23 @@ main(int argc, char **argv)
>   		/* init port */
>   		printf("Initializing port %u... ", portid);
>   		fflush(stdout);
> +		rte_eth_dev_info_get(portid, &dev_info);
> +		if ((dev_info.rx_offload_capa & port_conf.rxmode.offloads) !=
> +		    port_conf.rxmode.offloads) {
> +			printf("Some Rx offloads are not supported "
> +			       "by port %d: requested 0x%lx supported 0x%lx\n",
> +			       portid, port_conf.rxmode.offloads,
> +			       dev_info.rx_offload_capa);
> +			port_conf.rxmode.offloads &= dev_info.rx_offload_capa;
> +		}
> +		if ((dev_info.tx_offload_capa & port_conf.txmode.offloads) !=
> +		    port_conf.txmode.offloads) {
> +			printf("Some Tx offloads are not supported "
> +			       "by port %d: requested 0x%lx supported 0x%lx\n",
> +			       portid, port_conf.txmode.offloads,
> +			       dev_info.tx_offload_capa);
> +			port_conf.txmode.offloads &= dev_info.tx_offload_capa;
> +		}
>   		ret = rte_eth_dev_configure(portid, 1, 1, &port_conf);
>   		if (ret < 0)
>   			rte_exit(EXIT_FAILURE, "Cannot configure device: err=%d, port=%u\n",
> @@ -674,9 +691,11 @@ main(int argc, char **argv)
>   
>   		/* init one RX queue */
>   		fflush(stdout);
> +		rxq_conf = dev_info.default_rxconf;
> +		rxq_conf.offloads = port_conf.rxmode.offloads;
>   		ret = rte_eth_rx_queue_setup(portid, 0, nb_rxd,
>   					     rte_eth_dev_socket_id(portid),
> -					     NULL,
> +					     &rxq_conf,
>   					     l2fwd_pktmbuf_pool);
>   		if (ret < 0)
>   			rte_exit(EXIT_FAILURE, "rte_eth_rx_queue_setup:err=%d, port=%u\n",
> @@ -684,9 +703,12 @@ main(int argc, char **argv)
>   
>   		/* init one TX queue on each port */
>   		fflush(stdout);
> +		txq_conf = dev_info.default_txconf;
> +		txq_conf.txq_flags = ETH_TXQ_FLAGS_IGNORE;
> +		txq_conf.offloads = port_conf.txmode.offloads;

It looks like it is not 100% equivalent. As far as I can see dev_info 
get does
not convert txq_flags to offloads in default_txconf and in any case 
txq_conf.offloads
are overwritten here. So, if PMD provides default txq_flags, it is lost.
If it is intentionally, it should be highlighted and explained.

>   		ret = rte_eth_tx_queue_setup(portid, 0, nb_txd,
>   				rte_eth_dev_socket_id(portid),
> -				NULL);
> +				&txq_conf);
>   		if (ret < 0)
>   			rte_exit(EXIT_FAILURE, "rte_eth_tx_queue_setup:err=%d, port=%u\n",
>   				ret, portid);




More information about the dev mailing list