[dpdk-dev] [RFC PATCH v4 0/4] eventtimer: introduce event timer adapter

Erik Gabriel Carrillo erik.g.carrillo at intel.com
Tue Nov 28 18:40:04 CET 2017


This set of RFC patches contains the same changes as the previous version,
but they are now broken up into multiple patches for easier review. 

This patch set produces the same checkpatch warnings as the previous version:
"macro with flow control" and "avoid externs".  I have left the macros in 
since such usage seems common in DPDK, and left the extern in the .c because
it is the only file that uses that symbol, and it seems better than creating 
a new header file that only contains the extern var.

v4
- Split changes into multiple patches for easier review

v3
- Reworked allocation and ops organization in common code based on feedback
  received from Jerin and Pavan. This will allow fast-path function pointers to 
  be dereferenced with one level of indirection with pointers valid in primary
  and secondary processes.
- Moved default software implementation from sw_evdev directory to eventdev
  library directory, which will allow it to be used by any eventdev PMD as an
  alternative to providing its own definitions.
- Reverted occurrences of id back to pointer to adapter struct in library API
- Added rte_event_timer_adapter_lookup() function back in

v2
- Added ops structure and stubbed out plugin for SW impl
- Added unit test stubs
- Replaced occurrences of "wheel" in API with "adapter"
- Replaced occurrences of pointer to struct rte_event_timer_adapter with ids
- Removed rte_event_timer_adapter_lookup() function
- Replaced RTE_EVENT_TIMER_SUCCESS_{ARM,CANCEL} states with
  RTE_EVENT_TIMER_ARMED

Erik Gabriel Carrillo (4):
  eventtimer: introduce event timer adapter
  eventtimer: add common code
  eventtimer: add default software implementation stub
  test: add event timer adapter auto-test

 doc/api/doxy-api-index.md                          |   1 +
 drivers/event/sw/sw_evdev.c                        |  16 +
 lib/librte_eventdev/Makefile                       |   4 +
 lib/librte_eventdev/rte_event_timer_adapter.c      | 428 +++++++++++++++++++++
 lib/librte_eventdev/rte_event_timer_adapter.h      | 427 ++++++++++++++++++++
 .../rte_event_timer_adapter_driver.h               | 159 ++++++++
 lib/librte_eventdev/rte_eventdev.h                 |   7 +-
 lib/librte_eventdev/rte_eventdev_pmd.h             |   7 +
 lib/librte_eventdev/rte_eventdev_version.map       |  15 +-
 lib/librte_eventdev/sw_event_timer_adapter.c       | 123 ++++++
 test/test/Makefile                                 |   1 +
 test/test/test_event_timer_adapter.c               | 249 ++++++++++++
 12 files changed, 1434 insertions(+), 3 deletions(-)
 create mode 100644 lib/librte_eventdev/rte_event_timer_adapter.c
 create mode 100644 lib/librte_eventdev/rte_event_timer_adapter.h
 create mode 100644 lib/librte_eventdev/rte_event_timer_adapter_driver.h
 create mode 100644 lib/librte_eventdev/sw_event_timer_adapter.c
 create mode 100644 test/test/test_event_timer_adapter.c

-- 
2.6.4



More information about the dev mailing list