[dpdk-dev] [PATCH v3 1/3] ethdev: add Rx HW timestamp capability

Shahaf Shuler shahafs at mellanox.com
Sun Oct 1 08:44:10 CEST 2017

Hi Andrew,

Friday, September 29, 2017 10:26 AM, Andrew Rybchenko:

>On 09/28/2017 07:48 PM, Raslan Darawsheh wrote:

>>Add a new offload capability flag for Rx HW timestamp and enabling/disabling

>>this via rte_eth_rxmode.
>I think it should be on top [1] and ideally follow a new offload API without
>addition of a new bit field which will be removed soon.
>Also, please, update documentation (doc/guides/nics/features.rst)
>[1] http://dpdk.org/ml/archives/dev/2017-September/076872.html<https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fml%2Farchives%2Fdev%2F2017-September%2F076872.html&data=02%7C01%7Cshahafs%40mellanox.com%7C029845c0b55d49299f3f08d5070b57e0%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636422667676863312&sdata=83RStoqLwxS55vOFENOq1BDsM%2BhN3QNldpTdfooZMck%3D&reserved=0>

I agree it should be on top of [1].
Unfortunately since the PMDs will move to the new API only on 18.02, and in the current state Rx offloads are disabled by default, there will be no way to enable this feature without a dedicated bit.

So my suggestion is to keep the timestamp bit on rxmode, and to update the convert function introduced on [1]. This bit will be removed along with the entire bit-field array once the old offloads API will be deprecated.

More information about the dev mailing list