[dpdk-dev] [PATCH v7 6/8] net/i40e: add FDIR support for GTP-C and GTP-U

Wu, Jingjing jingjing.wu at intel.com
Thu Oct 5 05:09:25 CEST 2017


> @@ -975,27 +1003,30 @@ i40e_flow_fdir_fill_eth_ip_head(const struct i40e_fdir_input
> *fdir_input,
>  	raw_pkt += sizeof(uint16_t);
>  	len += sizeof(uint16_t);
> 
> -	switch (fdir_input->pctype) {
> -	case I40E_FILTER_PCTYPE_L2_PAYLOAD:
> +	if (is_customized_pctype) {
> +		cus_pctype = i40e_flow_fdir_find_customized_pctype(pf, pctype);
> +		if (!cus_pctype)
> +			PMD_DRV_LOG(ERR, "unknown pctype %u.",
> +				    fdir_input->pctype);
Doesn't return here?
If it is impossible cus_pctype is NULL, the check is unnecessary.
Because you used the cus_ptype below.

Thanks
Jingjing



More information about the dev mailing list