[dpdk-dev] [PATCH v5 2/9] lib/librte_power: add extra msg type for policies

[Hunt, David]

Hi Santosh,


On 4/10/2017 4:47 PM, santosh wrote:
> Hi David,
>
>
> On Wednesday 04 October 2017 08:55 PM, David Hunt wrote:
>> Signed-off-by: Nemanja Marjanovic <nemanja.marjanovic at intel.com>
>> Signed-off-by: Rory Sexton <rory.sexton at intel.com>
>> Signed-off-by: David Hunt <david.hunt at intel.com>
>> ---
> Glad that ifdef clutter removed.
> Few nits though..
>
>>   lib/librte_power/channel_commands.h | 42 +++++++++++++++++++++++++++++++++++++
>>   1 file changed, 42 insertions(+)
>>
>> diff --git a/lib/librte_power/channel_commands.h b/lib/librte_power/channel_commands.h
>> index 484085b..020d9fe 100644
>> --- a/lib/librte_power/channel_commands.h
>> +++ b/lib/librte_power/channel_commands.h
>> @@ -46,6 +46,7 @@ extern "C" {
>>   /* Valid Commands */
>>   #define CPU_POWER               1
>>   #define CPU_POWER_CONNECT       2
>> +#define PKT_POLICY              3
>>   
>>   /* CPU Power Command Scaling */
>>   #define CPU_POWER_SCALE_UP      1
>> @@ -54,11 +55,52 @@ extern "C" {
>>   #define CPU_POWER_SCALE_MIN     4
>>   #define CPU_POWER_ENABLE_TURBO  5
>>   #define CPU_POWER_DISABLE_TURBO 6
>> +#define HOURS 24
>> +
>> +#define MAX_VFS 10
>> +
>> +#define MAX_VCPU_PER_VM         8
>> +
>> +typedef enum {false, true} bool;
>> +
> do we really need typedef for bool; can't we simply
> use bool data-type?

Sure, will fix.

>> +struct t_boost_status {
>> +	bool tbEnabled;
>> +};
>> +
>> +struct timer_profile {
>> +	int busy_hours[HOURS];
>> +	int quiet_hours[HOURS];
>> +	int hours_to_use_traffic_profile[HOURS];
>> +};
>> +
>> +enum workload {HIGH, MEDIUM, LOW};
>> +enum policy_to_use {
>> +	TRAFFIC,
>> +	TIME,
>> +	WORKLOAD
>> +};
>> +
>> +struct traffic {
>> +	uint32_t min_packet_thresh;
>> +	uint32_t avg_max_packet_thresh;
>> +	uint32_t max_max_packet_thresh;
>> +};
>>   
>>   struct channel_packet {
>>   	uint64_t resource_id; /**< core_num, device */
>>   	uint32_t unit;        /**< scale down/up/min/max */
>>   	uint32_t command;     /**< Power, IO, etc */
>> +	char vm_name[32];
>> +
> How about const char * Or in case not possible then #define RTE_xx 32 Or
> use existing RTE_ for same purpose or some micro local to power lib.

I'll change to use an existing RTE_xx.

--snip--

Thanks,
Dave.