[dpdk-dev] [PATCH v5 3/4] app/testpmd: add raw flow type to flow director

Wu, Jingjing jingjing.wu at intel.com
Fri Oct 13 05:27:10 CEST 2017

>  		break;
> +	case RTE_ETH_FLOW_RAW:
> +		raw_packet_buff = open_ddp_package_file(res->filepath,
> +							&raw_packet_size);

If you think open_ddp_package_file can be used for common binary file open,
could you rename it and then use it? Because it is not ddp file, right?
The buffer is allocated in open_ddp_package_file, after you use it, you need
to free it to avoid memory leak, or call close_ddp_package_file.

Even the ethdev patch is been rejected, and you may go to a private API way.
I think the comments are also worth for the raw package read.
Please pay attention in later version.


More information about the dev mailing list