[dpdk-dev] [dpdk-stable] [PATCH] l3fwd-acl: fix unchecked return value

Thomas Monjalon thomas at monjalon.net
Sat Oct 14 00:43:32 CEST 2017


11/10/2017 09:07, Yang, Zhiyong:
> Hi Kuba,
> 
> Just a soft reminder.  :) 
> Maintainers will make the decision.
> 
> Ferruh,  Thomas,
> 
> Your opinion?

No need to re-send.

More comments:
- do not top reply
- title should start with examples/
- use --in-reply-to when sending a new version

Thanks


> > -----Original Message-----
> > From: Kozak, KubaX
> > Sent: Wednesday, October 11, 2017 2:58 PM
> > To: Yang, Zhiyong <zhiyong.yang at intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev at intel.com>
> > Cc: dev at dpdk.org; stable at dpdk.org; Jastrzebski, MichalX K
> > <michalx.k.jastrzebski at intel.com>
> > Subject: RE: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value
> > 
> > Thanks Zhiyong,
> > 
> > Should I correct this patch and resend to dpdk or is it just a suggestion for future?
> > 
> > Regards,
> > Kuba
> > 
> > >-----Original Message-----
> > >From: Yang, Zhiyong
> > >Sent: Tuesday, October 10, 2017 08:56
> > >To: Kozak, KubaX <kubax.kozak at intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev at intel.com>
> > >Cc: dev at dpdk.org; Kozak, KubaX <kubax.kozak at intel.com>; stable at dpdk.org
> > >Subject: RE: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value
> > >
> > >Hi,kubax,
> > >
> > >When you form the patch , you should add v2 and changes in v2.
> > >Besides that,  please be free to add
> > >Acked-by: zhiyong yang<zhiyong.yang at intel.com>
> > >
> > >Thanks
> > >Zhiyong
> > >
> > >> -----Original Message-----
> > >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Kuba Kozak
> > >> Sent: Tuesday, October 3, 2017 7:48 PM
> > >> To: Ananyev, Konstantin <konstantin.ananyev at intel.com>
> > >> Cc: dev at dpdk.org; Kozak, KubaX <kubax.kozak at intel.com>;
> > stable at dpdk.org
> > >> Subject: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value
> > >>
> > >> Add return value check and error handling for fseek call.
> > >>
> > >> Coverity issue: 143435
> > >> Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl")
> > >> Cc: konstantin.ananyev at intel.com
> > >> Cc: stable at dpdk.org
> > >>
> > >> Signed-off-by: Kuba Kozak <kubax.kozak at intel.com>
> > >> Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
> > >> ---
> 





More information about the dev mailing list