[dpdk-dev] [PATCH 0/5] Merge Linux and BSD EAL map files

Bruce Richardson bruce.richardson at intel.com
Thu Oct 19 18:36:24 CEST 2017


Both Linux and BSD EALs should provide exactly the same set of functions
to the user, even if in some cases the function is a stub returning
ENOTSUP. Because of this we should only need a single version.map file for
all of EAL - not one each for Linux and FreeBSD.

Unfortunately, there was some inconsistencies in the two EALs, specifically
4 functions were missing from the BSD interrupts files. As part of adding
the needed stubs, I also discovered that there was nothing terribly
Linux-specific about the Linux-specific rte_interrupts.h file, which
appeared to contain a superset of the BSD contents. Therefore, this file
could be made common also.

The net result is that there are now zero BSD-specific EAL headers, and
only a single Linux one for KNI. The version.map file is now moved to a
common location also, just inside rte_eal directory.

[While an argument could be made to put it in common, this location works
best for integration with the existing meson build-sysetm work. It also
allows the same version file to be used for non-posix-like environments
which may not use the "common" folder as much]


Bruce Richardson (5):
  eal/bsdapp: align interrupt include file with Linux version
  eal/bsdapp: fix missing interrupt stub functions
  eal: merge bsdapp and linuxapp interrupt headers
  eal: mark internal interrupts file as such to doxygen
  eal: use a single version map file

 lib/librte_eal/bsdapp/eal/Makefile                 |   4 +-
 lib/librte_eal/bsdapp/eal/eal_interrupts.c         |  35 +++
 .../bsdapp/eal/include/exec-env/rte_interrupts.h   | 137 -----------
 lib/librte_eal/bsdapp/eal/rte_eal_version.map      | 250 ---------------------
 lib/librte_eal/common/Makefile                     |   3 +-
 .../include/rte_eal_interrupts.h}                  |  24 +-
 lib/librte_eal/common/include/rte_interrupts.h     |   2 +-
 lib/librte_eal/linuxapp/eal/Makefile               |   4 +-
 .../{linuxapp/eal => }/rte_eal_version.map         |   0
 9 files changed, 59 insertions(+), 400 deletions(-)
 delete mode 100644 lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h
 delete mode 100644 lib/librte_eal/bsdapp/eal/rte_eal_version.map
 rename lib/librte_eal/{linuxapp/eal/include/exec-env/rte_interrupts.h => common/include/rte_eal_interrupts.h} (93%)
 rename lib/librte_eal/{linuxapp/eal => }/rte_eal_version.map (100%)

-- 
2.13.6



More information about the dev mailing list