[dpdk-dev] [PATCH v2 1/6] examples/ipsec-secgw: fix initialization of aead crypto devices

Aviad Yehezkel aviadye at dev.mellanox.co.il
Sun Oct 22 09:21:42 CEST 2017

On 10/20/2017 12:50 PM, De Lara Guarch, Pablo wrote:
>> -----Original Message-----
>> From: aviadye at dev.mellanox.co.il [mailto:aviadye at dev.mellanox.co.il]
>> Sent: Thursday, October 19, 2017 7:53 PM
>> To: dev at dpdk.org; Gonzalez Monroy, Sergio
>> <sergio.gonzalez.monroy at intel.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch at intel.com>; aviadye at mellanox.com
>> Cc: borisp at mellanox.com; akhil.goyal at nxp.com;
>> hemant.agrawal at nxp.com; Nicolau, Radu <radu.nicolau at intel.com>;
>> Doherty, Declan <declan.doherty at intel.com>; aviadye at dev.mellanox.co.il;
>> liranl at mellanox.com; nelio.laranjeiro at 6wind.com; thomas at monjalon.net
>> Subject: [dpdk-dev][PATCH v2 1/6] examples/ipsec-secgw: fix initialization
>> of aead crypto devices
>> From: Aviad Yehezkel <aviadye at mellanox.com>
>> Fixes: 501e9c226adf ("examples/ipsec-secgw: add AEAD parameters")
>> Cc: pablo.de.lara.guarch at intel.com
> You should CC stable here.
You referred me to http://dpdk.org/doc/guides/contributing/patches.html
I followed the documentation:
When fixing a regression, it is required to reference the id of the 
commit which introduced the bug, and put the original author of that 
commit on CC. Yiu can generate the required lines using the following 
git alias, which print the commit SHA and the author of the original code:
git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h 
(\"%s\")%nCc: %ae'"
Please explain when to use above alias and when to put stable or 
something else.

>> Issue: None
> What does this mean? This is a fix to an existing issue,
> so this doesn't make sense.
This is leftovers from my internal git continuous integration system. It 
refers to internal bug in my local bugzilla.
Will remove that and automate next patches not to include it.

> Apart from this:
> Acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>

More information about the dev mailing list