[dpdk-dev] [pktgen] [PATCH] Fix the protocol settings with the range command.

Bing Zhao ilovethull at 163.com
Tue Oct 24 10:37:18 CEST 2017


A "%" is missing in the command line, so the parameter comparison always returns failure. And the local variable "what" points to the argv[4], it is incorrect for this command since the argc is 4 and the max should be argv[3].

Signed-off-by: bing.zhao at hxt-semitech.com
Signed-off-by: jie2.liu at hxt-semitech.com
Signed-off-by: jia.he at hxt-semitech.com

---
 app/cli-functions.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/cli-functions.c b/app/cli-functions.c
index 076b86e..5e58f9c 100644
--- a/app/cli-functions.c
+++ b/app/cli-functions.c
@@ -150,7 +150,7 @@ static struct cli_map range_map[] = {
 	{ 31, "range %P src ip "SMMI" %4" },
 	{ 32, "range %P dst ip %4 %4 %4 %4" },
 	{ 33, "range %P src ip %4 %4 %4 %4" },
-	{ 40, "range %P proto tcp|udp" },
+	{ 40, "range %P proto %|tcp|udp" },
 	{ 50, "range %P dst port "SMMI" %d" },
 	{ 51, "range %P src port "SMMI" %d" },
 	{ 52, "range %P dst port %d %d %d %d" },
@@ -280,7 +280,7 @@ range_cmd(int argc, char **argv)
 			break;
 		case 40:
 			foreach_port(portlist,
-				range_set_proto(info, what) );
+				range_set_proto(info, argv[3]) );
 			break;
 		case 50:
 			foreach_port(portlist,
-- 
2.11.0.windows.1




More information about the dev mailing list