[dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

Gaetan Rivet gaetan.rivet at 6wind.com
Tue Oct 24 12:35:36 CEST 2017


This flag was deprecated in the previous release, and this is its removal.

We are going from an explicit support of device detach, to an implicit one,
with specific checks in place for PMDs not supporting the feature.

Attempting to Cc all relevant maintainers:

Cc: Ajit Khaparde <ajit.khaparde at broadcom.com>
Cc: Alejandro Lucero <alejandro.lucero at netronome.com>
Cc: Beilei Xing <beilei.xing at intel.com>
Cc: Bruce Richardson <bruce.richardson at intel.com>
Cc: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
Cc: Declan Doherty <declan.doherty at intel.com>
Cc: Ferruh Yigit <ferruh.yigit at intel.com>
Cc: Jing Chen <jing.d.chen at intel.com>
Cc: John Miller <john.miller at atomicrules.com>
Cc: John W. Linville <linville at tuxdriver.com>
Cc: Konstantin Ananyev <konstantin.ananyev at intel.com>
Cc: Matt Peters <matt.peters at windriver.com>
Cc: Nelio Laranjeiro <nelio.laranjeiro at 6wind.com>
Cc: Pascal Mazon <pascal.mazon at 6wind.com>
Cc: Shrikrishna Khare <skhare at vmware.com>
Cc: Srisivasubramanian Srinivasan <ssrinivasan at cavium.com>
Cc: Tetsuya Mukawa <mtetsuyah at gmail.com>
Cc: Wenzhuo Lu <wenzhuo.lu at intel.com>
Cc: Yongseok Koh <yskoh at mellanox.com>

Sorry for any undue ML traffic going your way if you are not interested
in this series.

I'd like to highlight Alejandro Lucero for the NFP PMD, as the patch is
somewhat more involved for this PMD and I don't have the hardware available
to validate the change.

v2:

  + Split ether patch:
    First remove the use of the flag, then remove the flag

  + Restore RTE_ETH_DEV_BONDED_SLAVE check,
    previously hastily removed along the DETACHABLE one.

  + Added release note, removed deprecation notice

Gaetan Rivet (6):
  ethdev: do not rely on detachable flag in detach
  ethdev: remove detachable device flag
  pci: propagate PMD removal error value for unplug
  doc: follow detachable flag disappearance
  doc: update detachable flag deprecation notice
  doc: note ether API change for detachable flag

 doc/guides/prog_guide/port_hotplug_framework.rst |  8 ++------
 doc/guides/rel_notes/deprecation.rst             |  8 --------
 doc/guides/rel_notes/release_17_11.rst           |  6 ++++++
 drivers/net/af_packet/rte_eth_af_packet.c        |  1 -
 drivers/net/ark/ark_ethdev.c                     |  1 -
 drivers/net/avp/avp_ethdev.c                     |  2 --
 drivers/net/bnxt/bnxt_ethdev.c                   |  1 -
 drivers/net/bonding/rte_eth_bond_pmd.c           |  3 +--
 drivers/net/e1000/em_ethdev.c                    |  1 -
 drivers/net/e1000/igb_ethdev.c                   |  2 --
 drivers/net/fm10k/fm10k_ethdev.c                 |  1 -
 drivers/net/i40e/i40e_ethdev.c                   |  1 -
 drivers/net/i40e/i40e_ethdev_vf.c                |  1 -
 drivers/net/ixgbe/ixgbe_ethdev.c                 |  2 --
 drivers/net/kni/rte_eth_kni.c                    |  2 --
 drivers/net/liquidio/lio_ethdev.c                |  1 -
 drivers/net/mlx4/mlx4.c                          |  1 -
 drivers/net/mlx5/mlx5.c                          |  1 -
 drivers/net/nfp/nfp_net.c                        | 19 ++++++++++++++---
 drivers/net/null/rte_eth_null.c                  |  2 --
 drivers/net/pcap/rte_eth_pcap.c                  |  1 -
 drivers/net/ring/rte_eth_ring.c                  |  1 -
 drivers/net/sfc/sfc_ethdev.c                     |  2 --
 drivers/net/softnic/rte_eth_softnic.c            |  1 -
 drivers/net/tap/rte_eth_tap.c                    |  2 +-
 drivers/net/vhost/rte_eth_vhost.c                |  3 +--
 drivers/net/virtio/virtio_ethdev.c               |  1 -
 drivers/net/virtio/virtio_user_ethdev.c          |  1 -
 drivers/net/vmxnet3/vmxnet3_ethdev.c             |  1 -
 lib/librte_eal/common/eal_common_pci.c           | 14 +++++++++----
 lib/librte_ether/rte_ethdev.c                    | 26 ++++++++----------------
 lib/librte_ether/rte_ethdev.h                    |  2 --
 32 files changed, 46 insertions(+), 73 deletions(-)

-- 
2.1.4



More information about the dev mailing list