[dpdk-dev] [PATCH 2/3] cryptodev: break dependency on virtual device bus

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Declan Doherty
> Sent: Friday, October 20, 2017 10:21 PM
> To: dev at dpdk.org
> Cc: Doherty, Declan <declan.doherty at intel.com>
> Subject: [dpdk-dev] [PATCH 2/3] cryptodev: break dependency on virtual
> device bus
> 
> Removes any dependency of librte_cryptodev on the virtual device
> infrastructure code and removes the functions which were virtual device
> specific.
> 
> Updates all virtual PMDs to remove dependencies on rte_cryptodev_vdev.h
> and replaces those calls with the new bus independent functions.
> 
> Signed-off-by: Declan Doherty <declan.doherty at intel.com>

...

> diff --git a/drivers/crypto/snow3g/rte_snow3g_pmd.c
> b/drivers/crypto/snow3g/rte_snow3g_pmd.c

...

> rte_vdev_device *vdev)  static int  cryptodev_snow3g_remove(struct
> rte_vdev_device *vdev)  {
> +	struct rte_cryptodev *cryptodev;
>  	const char *name;
> 
>  	name = rte_vdev_device_name(vdev);
>  	if (name == NULL)
>  		return -EINVAL;
> 
> -	RTE_LOG(INFO, PMD, "Closing SNOW 3G crypto device %s"
> +	RTE_LOG(INFO, PMD, "Closing KASUMI crypto device %s"

This should not be changed.

...

> +++ b/drivers/crypto/zuc/rte_zuc_pmd.c

...

> static int  cryptodev_zuc_remove(struct rte_vdev_device *vdev)  {
> +
> +	struct rte_cryptodev *cryptodev;
>  	const char *name;
> 
>  	name = rte_vdev_device_name(vdev);
>  	if (name == NULL)
>  		return -EINVAL;
> 
> -	RTE_LOG(INFO, PMD, "Closing ZUC crypto device %s"
> +	RTE_LOG(INFO, PMD, "Closing KASUMI crypto device %s"

This should not be changed.

...

> diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map
> b/lib/librte_cryptodev/rte_cryptodev_version.map
> index a0ea7bf..d3e4515 100644
> --- a/lib/librte_cryptodev/rte_cryptodev_version.map
> +++ b/lib/librte_cryptodev/rte_cryptodev_version.map
> @@ -73,8 +73,6 @@ DPDK_17.08 {
>  	rte_cryptodev_sym_capability_check_aead;
>  	rte_cryptodev_sym_session_init;
>  	rte_cryptodev_sym_session_clear;
> -	rte_cryptodev_vdev_parse_init_params;
> -	rte_cryptodev_vdev_pmd_init;
>  	rte_crypto_aead_algorithm_strings;
>  	rte_crypto_aead_operation_strings;

Release notes should be updated, since these two functions are being removed.
Also, rte_cryptodev_vdev_pmd_init function was going to be declared static in this release,
so the note in deprecation.rst should be removed.

> 
> --
> 2.9.4