[dpdk-dev] [PATCH] vfio: check ioctl return value

Jonas Pfefferle jpf at zurich.ibm.com
Thu Oct 26 17:13:04 CEST 2017


Check return value of device reset ioctl

Fixes: 33604c31354a ("vfio: refactor PCI BAR mapping")
Coverity issue: 195003

Signed-off-by: Jonas Pfefferle <jpf at zurich.ibm.com>
---
 lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
index d407c87..d5f6637 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
@@ -333,7 +333,11 @@ pci_vfio_setup_device(struct rte_pci_device *dev, int vfio_dev_fd)
 	}
 
 	/* Reset the device */
-	ioctl(vfio_dev_fd, VFIO_DEVICE_RESET);
+	if (ioctl(vfio_dev_fd, VFIO_DEVICE_RESET)) {
+		RTE_LOG(ERR, EAL, "Unable to reset device! Error: %d (%s)\n",
+				errno, strerror(errno));
+		return -1;
+    }
 
 	return 0;
 }
-- 
2.7.4



More information about the dev mailing list