[dpdk-dev] [PATCH v9 3/4] bus/vdev: move to vdev bus to drivers/bus

Tan, Jianfeng jianfeng.tan at intel.com
Fri Oct 27 10:19:25 CEST 2017



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Friday, October 27, 2017 3:56 PM
> To: Tan, Jianfeng
> Cc: dev at dpdk.org; jblunck at infradead.org; Richardson, Bruce; Ananyev,
> Konstantin; De Lara Guarch, Pablo; yliu at fridaylinux.org;
> maxime.coquelin at redhat.com; mtetsuyah at gmail.com; Yigit, Ferruh
> Subject: Re: [PATCH v9 3/4] bus/vdev: move to vdev bus to drivers/bus
> 
> 27/10/2017 03:06, Jianfeng Tan:
> > --- /dev/null
> > +++ b/drivers/bus/vdev/rte_bus_vdev_version.map
> > @@ -0,0 +1,8 @@
> > +DPDK_17.11 {
> > +       global:
> > +
> > +       rte_vdev_init;
> > +       rte_vdev_register;
> > +       rte_vdev_uninit;
> > +       rte_vdev_unregister;
> > +};
> 
> It should not be needed to export the driver ops.

rte_vdev_register/unregister are needed by vdev PMDs, which are needed to export, isn't it?

And for rte_vdev_init()/rte_vdev_uninit(), do you mean we all change to use rte_eal_dev_attach()/detach()?

> 
> Please can you try to make it private?

Even we want to make it private, I think it needs deprecation notice, which we can further improved for the next release?

Thanks,
Jianfeng



More information about the dev mailing list