[dpdk-dev] [PATCH] net/failsafe: fix adding MAC error report miss

[Gaëtan Rivet]

On Sun, Sep 03, 2017 at 06:26:45PM +0300, Matan Azrad wrote:
> The corrupted code don't reply error in case of MAC
> address adding failure while failsafe PMD was trying
> to apply configuration to the sub device.
> 
> Hence, the application may get unwanted packets.
> 
> The fix adds error report for this case.
> 
> Fixes: ebea83f899d8 ("net/failsafe: add plug-in support")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Matan Azrad <matan at mellanox.com>
Acked-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
> ---
>  drivers/net/failsafe/failsafe_ether.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c
> index a3a8cce..fb9bbce 100644
> --- a/drivers/net/failsafe/failsafe_ether.c
> +++ b/drivers/net/failsafe/failsafe_ether.c
> @@ -203,6 +203,7 @@ fs_eth_dev_conf_apply(struct rte_eth_dev *dev,
>  
>  			ether_format_addr(ea_fmt, ETHER_ADDR_FMT_SIZE, ea);
>  			ERROR("Adding MAC address %s failed", ea_fmt);
> +			return ret;
>  		}
>  	}
>  	/* VLAN filter */
> -- 
> 2.7.4
> 

-- 
Gaëtan Rivet
6WIND