[dpdk-dev] [PATCH v5 5/8] mempool: get the mempool capability
olivier.matz at 6wind.com
Thu Sep 7 10:39:24 CEST 2017
On Thu, Sep 07, 2017 at 01:45:58PM +0530, santosh wrote:
> > The API is correct, but the flags should simply be returned, not or-ed.
> > I think it should be kept as simple as possible: a function called
> > get_somthing() is expected to return it without doing anything else.
> > Sorry if I wasn't clear in my previous message.
> > If there is a need to do a OR with mp->flags, it has to be done in the caller,
> > i.e. rte_mempool_populate_default().
> pl. confirm : you want below approach:
> unsigned int flags;
> rte_mempool_ops_get_capabilities(mp, &flags)
> mp->flags |= flags;
> is that okay with you? i'll queue in v6
More information about the dev