[dpdk-dev] [PATCH 1/6] testpmd: remove unnecessary void casts

Ferruh Yigit ferruh.yigit at intel.com
Mon Sep 11 14:44:43 CEST 2017


On 8/23/2017 4:44 PM, Stephen Hemminger wrote:
> The testpmd was doing old BSD lint style casts of rte_memcpy
> to (void). This is unnecessary.
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>

<...>

> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2173,7 +2173,7 @@ init_port_dcb_config(portid_t pid,
>  	 * Set the numbers of RX & TX queues to 0, so
>  	 * the RX & TX queues will not be setup.
>  	 */
> -	(void)rte_eth_dev_configure(pid, 0, 0, &port_conf);
> +	rte_eth_dev_configure(pid, 0, 0, &port_conf);
>  
>  	rte_eth_dev_info_get(pid, &rte_port->dev_info);

According cover letter, intention seems as removing void casts for
rte_memcpy, and all other updates except this one is for rte_memcpy.

Is above change intentional?


More information about the dev mailing list