[dpdk-dev] [PATCH 07/10] metrics: fix compilation with -Og

Olivier Matz olivier.matz at 6wind.com
Mon Sep 11 17:13:30 CEST 2017

The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following

  CC rte_metrics.o
  rte_metrics.c: In function
  ‘rte_metrics_reg_names’: rte_metrics.c:153:22: error: ‘entry’
                           may be used uninitialized in this function
    entry->idx_next_set = 0;

This is a false positive, gcc is not able to see that we always go in
the loop at least once, initializing entry.

Fix the warning by initializing entry to NULL.

Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
 lib/librte_metrics/rte_metrics.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c
index b66a72bb0..d9404001a 100644
--- a/lib/librte_metrics/rte_metrics.c
+++ b/lib/librte_metrics/rte_metrics.c
@@ -115,7 +115,7 @@ rte_metrics_reg_name(const char *name)
 rte_metrics_reg_names(const char * const *names, uint16_t cnt_names)
-	struct rte_metrics_meta_s *entry;
+	struct rte_metrics_meta_s *entry = NULL;
 	struct rte_metrics_data_s *stats;
 	const struct rte_memzone *memzone;
 	uint16_t idx_name;

More information about the dev mailing list