[dpdk-dev] [PATCH] test: fix wrong assignment operation

Yang, Zhiyong zhiyong.yang at intel.com
Fri Sep 15 04:42:28 CEST 2017


Sorry. I make a mistake in Cc: email address.  This one is Superseded. 

> -----Original Message-----
> From: Yang, Zhiyong
> Sent: Friday, September 15, 2017 10:16 AM
> To: dev at dpdk.org
> Cc: Wodkowski; Wodkowski, PawelX <pawelx.wodkowski at intel.com>; Kulasek;
> Kulasek, TomaszX <tomaszx.kulasek at intel.com>; Doherty, Declan
> <declan.doherty at intel.com>; Yang, Zhiyong <zhiyong.yang at intel.com>
> Subject: [PATCH] test: fix wrong assignment operation
> 
> It should be an comparation operation rather than an assignment operation.
> 
> Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4")
> 
> cc: Wodkowski, PawelX <pawelx.wodkowski at intel.com>
> cc: Kulasek, TomaszX <tomaszx.kulasek at intel.com>
> cc: Declan Doherty <declan.doherty at intel.com>
> Signed-off-by: Zhiyong Yang <zhiyong.yang at intel.com>
> ---
>  test/test/test_link_bonding_mode4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/test/test_link_bonding_mode4.c
> b/test/test/test_link_bonding_mode4.c
> index 8e9e23db5..e246f0148 100644
> --- a/test/test/test_link_bonding_mode4.c
> +++ b/test/test/test_link_bonding_mode4.c
> @@ -661,7 +661,7 @@ bond_handshake(void)
>  	TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n");
> 
>  	/* If flags doesn't match - report failure */
> -	return all_slaves_done = 1 ? TEST_SUCCESS : TEST_FAILED;
> +	return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED;
>  }
> 
>  #define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports)
> --
> 2.13.3



More information about the dev mailing list