[dpdk-dev] [PATCH 2/4] net/axgbe : Add PMD support for AMD XGBE Ethernet

[Kumar, Ravi1]

>On 9/13/2017 6:47 PM, Ravi Kumar wrote:
>> Signed-off-by: Ravi Kumar <ravi1.kumar at amd.com>
><...>
>
>> +#
>> +# Export include files
>> +#
>> +SYMLINK-y-include += axgbe_ethdev.h
>> +SYMLINK-y-include += axgbe_rxtx.h
>> +SYMLINK-y-include += axgbe_common.h
>> +SYMLINK-y-include += axgbe_phy.h
>
>Are these need to be public header? If not just delete above lines.

Thanks a lot for all the review comments Ferruh. We are working to address your comments on all our patches. 

Regards,
Ravi
>> +
>> +# this lib depends upon:
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_AXGBE_PMD) += lib/librte_eal
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_AXGBE_PMD) += lib/librte_mbuf
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_AXGBE_PMD) += lib/librte_mempool
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_AXGBE_PMD) += lib/librte_ether
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_AXGBE_PMD) += lib/librte_kvargs
>
>No more required, above drivers/net/Makefile update already does the work, this can be removed.
>
><...>
>
>> +#define min_t(type, x, y) ({                    \
>> +	type __min1 = (x);                      \
>> +	type __min2 = (y);                      \
>> +	__min1 < __min2 ? __min1 : __min2; })
>> +
>> +#define max_t(type, x, y) ({                    \
>> +	type __max1 = (x);                      \
>> +	type __max2 = (y);                      \
>> +	__max1 > __max2 ? __max1 : __max2; })
>
>You can use RTE_MIN, RTE_MAX
>
>> +
>> +#define AXGBE_REG_WRITE(val, reg) do { \
>> +	(*((volatile uint32_t *) (reg))) = val; \ } while (0)
>> +
>> +static inline uint32_t ioread32(uint64_t addr) {
>
>You can use rte equvalent functions, rte_read32 or rte_read32_relaxed please check rte_io.h
>
><...>
>
>> +	pci_dev = RTE_DEV_TO_PCI(eth_dev->device);
>> +	pdata->pci_dev = pci_dev;
>> +	rte_eth_copy_pci_info(eth_dev, pci_dev);
>
>This should be already done by rte_eth_dev_pci_generic_probe()
>
><...>