[dpdk-dev] [PATCH v2] examples/l2fwd-cat: fix build according to API changes
bruce.richardson at intel.com
Mon Sep 18 18:18:00 CEST 2017
On Mon, Sep 18, 2017 at 07:07:18PM +0300, Vladimir Kuramshin wrote:
> I agree with you but the problem is that in this case I should also change
> Makefile in order to add version checking there also but I don't know how to
> write correct condition in Makefile that checks if it's higher or lower
> version, e.g. if PQOS_VERSION > 1.3 then ... else ...
> If there was some spec file I'd add such checking there but I have Makefile
> Vladimir Kuramshin
Yes, good point. However, if at least the check was in the C file, if
the build fails, the user can be given a clear message as to why it
That can be another patch for another day, however.
> On 18.09.2017 17:49, Bruce Richardson wrote:
> > On Thu, Sep 07, 2017 at 02:45:27PM +0300, Vladimir Kuramshin wrote:
> > > Current version is compatible with PQOS version 1.3
> > > but not compatible with higher versions. This change
> > > makes l2fwd-cat example compatible with versions since 1.4
> > >
> > > Signed-off-by: Vladimir Kuramshin <v.kuramshin at samsung.com>
> > > ---
> > > Version 2 changes: fixed checkpatch warnings
> > > "Prefer 'unsigned int *' to bare use of 'unsigned *'"
> > >
> > I can confirm this at least allows the code to compile with the latest
> > versions of the pqos library, which is currently broken.
> > One enhancement might be to put into our code a check for PQOS_VERSION
> > from pqos.h (which is, interestingly enough, currently at 1.1), to flag
> > when we have an unsupported version - right now one that is too old.
> > Otherwise, this is a good fix to have.
> > Acked-by: Bruce Richardson <bruce.richardson at intel.com>
More information about the dev