[dpdk-dev] [PATCH v5 2/5] cfgfile: change existing API functions
Thomas Monjalon
thomas at monjalon.net
Tue Sep 19 23:26:46 CEST 2017
Hi,
19/09/2017 13:07, Kuba Kozak:
> @@ -409,7 +407,11 @@ rte_cfgfile_section_num_entries(struct rte_cfgfile *cfg,
> {
> const struct rte_cfgfile_section *s = _get_section(cfg, sectionname);
> if (s == NULL)
> +#ifdef RTE_NEXT_ABI
> + return -EINVAL;
> +#else
> return -1;
> +#endif
> return s->num_entries;
> }
Why are you using RTE_NEXT_ABI?
Can you wait 18.02 to make this change?
Anyway, when breaking the API you need to update tha API section
of the release notes.
> @@ -219,7 +219,7 @@ int rte_cfgfile_section_num_entries_by_index(struct rte_cfgfile *cfg,
> * @param max_entries
> * Maximum number of section entries to be stored in entries array
> * @return
> -* Number of entries populated on success, -1 otherwise
> +* Number of entries populated on success, -EINVAL otherwise
> */
This documentation become wrong if RTE_NEXT_ABI is disabled.
More information about the dev
mailing list