[dpdk-dev] [PATCH v4 3/4] net/softnic: add TM capabilities ops

[Singh, Jasvinder]

> Hi Jasvinder,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jasvinder Singh
> > Sent: Monday, September 18, 2017 5:10 PM
> > To: dev at dpdk.org
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu at intel.com>; Yigit,
> > Ferruh <ferruh.yigit at intel.com>; thomas at monjalon.net
> > Subject: [dpdk-dev] [PATCH v4 3/4] net/softnic: add TM capabilities
> > ops
> >
> > Implement ethdev TM capability APIs in SoftNIC PMD.
> >
> > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
> > Signed-off-by: Jasvinder Singh <jasvinder.singh at intel.com>
> > ---
> >  drivers/net/softnic/rte_eth_softnic.c           |  12 +-
> >  drivers/net/softnic/rte_eth_softnic_internals.h |  32 ++
> >  drivers/net/softnic/rte_eth_softnic_tm.c        | 500
> > ++++++++++++++++++++++++
> >  3 files changed, 543 insertions(+), 1 deletion(-)
> The same concern of the naming as patch 2.The function and structure
> names are too common. Better add the prefix 'softnic_' too.
> Except that, the patch looks good to me.

Ok, Thanks. Will clarity and add comments as well.