[dpdk-dev] [PATCH v6 2/8] net/i40e: update ptype and pctype info

[Wu, Jingjing]

> -----Original Message-----
> From: Xing, Beilei
> Sent: Friday, September 29, 2017 1:19 PM
> To: Wu, Jingjing <jingjing.wu at intel.com>
> Cc: Chilikin, Andrey <andrey.chilikin at intel.com>; dev at dpdk.org
> Subject: [PATCH v6 2/8] net/i40e: update ptype and pctype info
> 
> Update new packet type and new pctype info when downloading
> profile.
> 
> Signed-off-by: Beilei Xing <beilei.xing at intel.com>

[......] 


> +	ret = rte_pmd_i40e_ptype_mapping_update(port_id, ptype_mapping,
> +						ptype_num, 0);
> +	if (ret) {
> +		PMD_DRV_LOG(ERR, "Failed to update mapping table.");
> +		rte_free(ptype_mapping);
> +		rte_free(ptype);
> +		return -1;
> +	}
> +
> +	rte_free(ptype_mapping);
> +	rte_free(ptype);
> +	return 0;

Minor comments, how about:
	if (ret)
		PMD_DRV_LOG(ERR, "Failed to update mapping table.");

	rte_free(ptype_mapping);
	rte_free(ptype);
	return ret;


Reviewed-by: Jingjing Wu <jingjing.wu at intel.com>