[dpdk-dev] [PATCH] app/testpmd: fix runtime dead code

Wu, Jingjing jingjing.wu at intel.com
Fri Sep 29 16:25:28 CEST 2017



> -----Original Message-----
> From: Jastrzebski, MichalX K
> Sent: Friday, September 29, 2017 8:57 PM
> To: Wu, Jingjing <jingjing.wu at intel.com>
> Cc: dev at dpdk.org; Jain, Deepak K <deepak.k.jain at intel.com>; Kulasek, TomaszX
> <tomaszx.kulasek at intel.com>; Chilikin, Andrey <andrey.chilikin at intel.com>;
> stable at dpdk.org
> Subject: [PATCH] app/testpmd: fix runtime dead code
> 
> From: Tomasz Kulasek <tomaszx.kulasek at intel.com>
> 
> Coverity reports DEADCODE, as assumes that RTE_LIBRTE_I40E_PMD
> is defined and function compiles entirely.
> The fix is about to place printf function into #else branch
> of conditional compilation, since it is known at compile
> time if i40e is supported. No need to check it at runtime.
> 
> Coverity issue: 158646
> Fixes: 37a56cce7b8e ("app/testpmd: enable DDP get info feature")
> Cc: andrey.chilikin at intel.com
> Cc: stable at dpdk.org
> 
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek at intel.com>
Acked-by: Jingjing Wu <jingjing.wu at intel.com>


More information about the dev mailing list