[dpdk-dev] [PATCH] ring: relax alignment constraint on ring structure

Jerin Jacob jerin.jacob at caviumnetworks.com
Tue Apr 3 17:07:23 CEST 2018


-----Original Message-----
> Date: Tue, 3 Apr 2018 15:26:44 +0200
> From: Olivier Matz <olivier.matz at 6wind.com>
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] ring: relax alignment constraint on ring
>  structure
> X-Mailer: git-send-email 2.11.0
> 
> The initial objective of
> commit d9f0d3a1ffd4 ("ring: remove split cacheline build setting")
> was to add an empty cache line betwee, the producer and consumer
> data (on platform with cache line size = 64B), preventing from
> having them on adjacent cache lines.
> 
> Following discussion on the mailing list, it appears that this
> also imposes an alignment constraint that is not required.
> 
> This patch removes the extra alignment constraint and adds the
> empty cache lines using padding fields in the structure. The
> size of rte_ring structure and the offset of the fields remain
> the same on platforms with cache line size = 64B:
> 
>   rte_ring = 384
>   rte_ring.name = 0
>   rte_ring.flags = 32
>   rte_ring.memzone = 40
>   rte_ring.size = 48
>   rte_ring.mask = 52
>   rte_ring.prod = 128
>   rte_ring.cons = 256
> 
> But it has an impact on platform where cache line size is 128B:
> 
>   rte_ring = 384        -> 768
>   rte_ring.name = 0
>   rte_ring.flags = 32
>   rte_ring.memzone = 40
>   rte_ring.size = 48
>   rte_ring.mask = 52
>   rte_ring.prod = 128   -> 256

Are we leaving TWO cacheline to make sure, HW prefetch don't load
the adjust cacheline(consumer)?

If so, Will it have impact on those machine where it is 128B Cache line
and the HW prefetcher is not loading the next caching explicitly. Right?

>   rte_ring.cons = 256   -> 512
> 
> Link: http://dpdk.org/dev/patchwork/patch/25039/
> Suggested-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>


More information about the dev mailing list