[dpdk-dev] Survey for final decision about per-port offload API

Yongseok Koh yskoh at mellanox.com
Wed Apr 4 02:25:57 CEST 2018


> On Mar 30, 2018, at 6:47 AM, Thomas Monjalon <thomas at monjalon.net> wrote:
> 
> There are some discussions about a specific part of the offload API:
> 	"To enable per-port offload, the offload should be set on both
> 	device configuration and queue setup."
> 
> It means the application must repeat the port offload flags
> in rte_eth_conf.[rt]xmode.offloads and rte_eth_[rt]xconf.offloads,
> when calling respectively rte_eth_dev_configure() and
> rte_eth_[rt]x_queue_setup for each queue.
> 
> The PMD must check if there is mismatch, i.e. a port offload not
> repeated in queue setup.
> There is a proposal to do this check at ethdev level:
> 	https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fml%2Farchives%2Fdev%2F2018-March%2F094023.html&data=02%7C01%7Cyskoh%40mellanox.com%7Cb2ae36d768424c9e616308d59644e2a7%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636580144979633174&sdata=pGxkC6H78h%2BaSVOYRjMguOu%2B1xIrzW7YbCfohmE8uvs%3D&reserved=0
> 
> It was also proposed to relax the API and allow "forgetting" port
> offloads in queue offloads:
> 	https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fml%2Farchives%2Fdev%2F2018-March%2F092978.html&data=02%7C01%7Cyskoh%40mellanox.com%7Cb2ae36d768424c9e616308d59644e2a7%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636580144979633174&sdata=MrHYsw6MRliU1IfBulcNxvKNX1JNrOrcs1NVIuK72ec%3D&reserved=0
> 
> It would mean the offloads applied to a queue result of OR operation:
> 	rte_eth_conf.[rt]xmode.offloads | rte_eth_[rt]xconf.offloads
> 
> 1/ Do you agree with above API change?
yes

> 
> 
> If we agree with this change, we need to update the documentation
> and remove the checks in PMDs.
> Note: no matter what is decided here, 18.05-rc1 should have all PMDs
> switched to the API which was defined in 17.11.
> Given that API is new and not yet adopted by the applications,
> the sonner it is fixed, the better.
> 
> 2/ Should we do this change in 18.05-rc2?
yes

> 
> 
> At the same time, we want to make clear that an offload enabled at
> port level, cannot be disabled at queue level.
> 
> 3/ Do you agree with above statement (to be added in the doc)?
yes

> 
> 
> There is the same kind of confusion in the offload capabilities:
> 	rte_eth_dev_info.[rt]x_offload_capa
> 	rte_eth_dev_info.[rt]x_queue_offload_capa
> The queue capabilities must be a subset of port capabilities,
> i.e. every queue capabilities must be reported as port capabilities.
> But the port capabilities should be reported at queue level
> only if it can be applied to a specific queue.
> 
> 4/ Do you agree with above statement (to be added in the doc)?
yes


Thanks,
Yongseok



More information about the dev mailing list