[dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

Shahaf Shuler shahafs at mellanox.com
Tue Apr 10 08:26:57 CEST 2018


Monday, March 26, 2018 12:35 PM, Adrien Mazarguil:
> Subject: Re: [PATCH v3] net/mlx4: support CRC strip toggling
> 
> On Sun, Mar 25, 2018 at 08:19:29PM +0000, Ophir Munk wrote:
> > Previous to this commit mlx4 CRC stripping was executed by default and
> > there was no verbs API to disable it.
> >
> > Signed-off-by: Ophir Munk <ophirmu at mellanox.com>
> > ---
> > v1: initial version
> > v2: following internal reviews
> > v3: following dpdk.org mailing list reviews
> 
> Except for the remaining extra space mentioned below :)
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil at 6wind.com>

It seems the direction of the KEEP_CRC flag discussion[1] is for the flag to be included only on 18.08.

Hence applying this patch (with the extra space removal). In case KEEP_CRC will be included on 18.05 we will have another patch to adjust. 

[1] https://dpdk.org/dev/patchwork/patch/36416/


More information about the dev mailing list