[dpdk-dev] [PATCH v4 06/16] ethdev: remove C99 flexible arrays from flow API
Thomas Monjalon
thomas at monjalon.net
Tue Apr 17 22:18:22 CEST 2018
16/04/2018 18:22, Adrien Mazarguil:
> This patch replaces C99-style flexible arrays in struct rte_flow_action_rss
> and struct rte_flow_item_raw with standard pointers to the same data.
>
> They proved difficult to use in the field (e.g. no possibility of static
> initialization) and unsuitable for C++ applications.
>
> Affected PMDs and examples are updated accordingly.
>
> This breaks ABI compatibility for the following public functions:
>
> - rte_flow_copy()
> - rte_flow_create()
> - rte_flow_query()
> - rte_flow_validate()
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil at 6wind.com>
> ---
> app/test-pmd/cmdline_flow.c | 117 +++++++++++++++++---------------
> app/test-pmd/config.c | 25 ++++---
> doc/guides/prog_guide/rte_flow.rst | 18 ++---
> drivers/net/mlx4/mlx4_flow.c | 22 +++---
> drivers/net/mlx5/mlx5_flow.c | 20 +++---
> examples/ipsec-secgw/ipsec.c | 17 ++---
> lib/librte_ether/rte_flow.c | 25 ++++---
> lib/librte_ether/rte_flow.h | 8 ++-
> 8 files changed, 135 insertions(+), 117 deletions(-)
There are almost as much insertions as deletions.
So it's probably not a bad move.
Acked-by: Thomas Monjalon <thomas at monjalon.net>
More information about the dev
mailing list