[dpdk-dev] [PATCH v4 04/11] net/mlx5: support Rx tunnel type identification

[Nélio Laranjeiro]

On Wed, Apr 18, 2018 at 02:33:01PM +0000, Xueming(Steven) Li wrote:
> 
> 
> > -----Original Message-----
> > From: Nélio Laranjeiro <nelio.laranjeiro at 6wind.com>
> > Sent: Wednesday, April 18, 2018 2:51 PM
> > To: Xueming(Steven) Li <xuemingl at mellanox.com>
> > Cc: Shahaf Shuler <shahafs at mellanox.com>; dev at dpdk.org
> > Subject: Re: [PATCH v4 04/11] net/mlx5: support Rx tunnel type identification
> > 
> > On Tue, Apr 17, 2018 at 11:14:29PM +0800, Xueming Li wrote:
> > > This patch introduced tunnel type identification based on flow rules.
> > > If flows of multiple tunnel types built on same queue,
> > > RTE_PTYPE_TUNNEL_MASK will be returned, user application could use
> > > bits in flow mark as tunnel type identifier.
> > 
> > As discussed in the previous thread, you cannot set all tunnel bits in the mbuf, it will break
> > existing applications.
> > 
> > This is an non announce API breakage.
> > 
> > Thanks,
> > 
> > --
> > Nélio Laranjeiro
> > 6WIND
> 
> There was another issue in code, please check below comments:
> http://www.dpdk.org/ml/archives/dev/2018-April/096991.html

I've already read this and I don't see anything related to changing the
meaning of the mbuf flags.

Such change is not announce, thus it cannot be accepted you must not set
any flag in the mbuf if it cannot clearly identify what is in the
packet.

Regards,

-- 
Nélio Laranjeiro
6WIND