[dpdk-dev] [PATCH v5 04/11] net/mlx5: support Rx tunnel type identification

Xueming(Steven) Li xuemingl at mellanox.com
Mon Apr 23 09:56:58 CEST 2018



> -----Original Message-----
> From: Nélio Laranjeiro <nelio.laranjeiro at 6wind.com>
> Sent: Monday, April 23, 2018 3:41 PM
> To: Xueming(Steven) Li <xuemingl at mellanox.com>
> Cc: Iremonger Bernard <bernard.iremonger at intel.com>; Shahaf Shuler <shahafs at mellanox.com>;
> dev at dpdk.org
> Subject: Re: [PATCH v5 04/11] net/mlx5: support Rx tunnel type identification
> 
> On Fri, Apr 20, 2018 at 08:23:33PM +0800, Xueming Li wrote:
> > This patch introduced tunnel type identification based on flow rules.
> > If flows of multiple tunnel types built on same queue,
> >RTE_PTYPE_TUNNEL_MASK will be returned, user application could use bits
> >in flow mark as tunnel type identifier.
> >[...]
> 
> There is still the issue about returning this wrong bits in the mbuf.
> 
> Bit in the mbuf ptypes must only reflect what is present in the mbuf, using RTE_PTYPE_TUNNEL_MASK
> means all tunnels are present in the packet which is absolutely wrong.
> 
> This behavior was not announce and breaks API/ABI.  It cannot be accepted yet.
> 
> I'll suggest to add a new RTE_PTYPE_TUNNEL_UNKNOWN which does not break the ABI or don't add such bits
> in the mbuf.
> 

Seems I forgot to update commit message. RTE_PTYPE_TUNNEL_UNKNOWN has been removed according to discussion.


> Regards,
> 
> --
> Nélio Laranjeiro
> 6WIND


More information about the dev mailing list