[dpdk-dev] [PATCH] doc: update bbdev library documentation

[Mokhtar, Amr]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Monday 23 April 2018 12:12
> To: Mokhtar, Amr <amr.mokhtar at intel.com>
> Cc: Chalupnik, KamilX <kamilx.chalupnik at intel.com>; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: update bbdev library documentation
> 
> 23/04/2018 12:56, Mokhtar, Amr:
> > From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > > 04/04/2018 16:05, KamilX Chalupnik:
> > > > From: "Chalupnik, KamilX" <kamilx.chalupnik at intel.com>
> > >
> > > >  doc/guides/prog_guide/bbdev.rst               | 247
> > > +++++++++++++++++++++++---
> > > >  doc/guides/prog_guide/img/turbo_tb_decode.png | Bin 0 -> 43552
> > > bytes
> > > >  doc/guides/prog_guide/img/turbo_tb_encode.png | Bin 0 -> 46944
> > > bytes
> > > >  3 files changed, 222 insertions(+), 25 deletions(-)
> > > >  create mode 100644
> doc/guides/prog_guide/img/turbo_tb_decode.png
> > > >  create mode 100644
> doc/guides/prog_guide/img/turbo_tb_encode.png
> > >
> > > No, sorry, you cannot add binary file in this repository.
> > > It is an Open Source project, we provide sources.
> > > For figures, the SVG format is preferred.
> > >
> > > I'm sorry that your Intel colleagues did not warn you.
> > >
> >
> > I wasn't aware there is specific preference for figures, this can be fixed.
> > There is no specific reason for choosing .png except that there are files
> already
> > in prog_guide/img/* of type .png. So it was assumed that its ok.
> > And BTW, did I miss it somewhere in DPDK documentation what
> particular image
> > types should be submitted.
> 
> Yes, it is in this doc:
> 	http://dpdk.org/doc/guides/contributing/documentation.html#ima
> ges
>

Ok, perfect. Will get it sorted accordingly..
Thanks!!

> > Will get this fixed. Thanks.
> 
> Thanks
>