[dpdk-dev] [PATCH] app/bbdev: dynamic lib support

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Chalupnik, KamilX
> Sent: Thursday, April 26, 2018 10:42 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; dev at dpdk.org
> Cc: Mokhtar, Amr <amr.mokhtar at intel.com>
> Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> 
> Hi Pablo,
> 
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Wednesday, April 25, 2018 6:11 PM
> > To: Chalupnik, KamilX <kamilx.chalupnik at intel.com>; dev at dpdk.org
> > Cc: Mokhtar, Amr <amr.mokhtar at intel.com>
> > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> >
> > Hi Kamil,
> >
> > > -----Original Message-----
> > > From: Chalupnik, KamilX
> > > Sent: Wednesday, April 25, 2018 9:43 AM
> > > To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>;
> > > dev at dpdk.org
> > > Cc: Mokhtar, Amr <amr.mokhtar at intel.com>
> > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > >
> > > Hi Pablo
> > >
> > > > -----Original Message-----
> > > > From: De Lara Guarch, Pablo
> > > > Sent: Tuesday, April 24, 2018 4:18 PM
> > > > To: Chalupnik, KamilX <kamilx.chalupnik at intel.com>; dev at dpdk.org
> > > > Cc: Mokhtar, Amr <amr.mokhtar at intel.com>; Chalupnik, KamilX
> > > > <kamilx.chalupnik at intel.com>
> > > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > > >
> > > > Hi Kamil,
> > > >
> > > > > -----Original Message-----
> > > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of KamilX
> > > > > Chalupnik
> > > > > Sent: Wednesday, April 4, 2018 3:06 PM
> > > > > To: dev at dpdk.org
> > > > > Cc: Mokhtar, Amr <amr.mokhtar at intel.com>; Chalupnik, KamilX
> > > > > <kamilx.chalupnik at intel.com>
> > > > > Subject: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > > > >
> > > > > From: "Chalupnik, KamilX" <kamilx.chalupnik at intel.com>
> > > > >
> > > > > Support for linking with dynamic library added in Baseband
> > > > > Device test application
> > > > >
> > > > > Signed-off-by: KamilX Chalupnik <kamilx.chalupnik at intel.com>
> > > > > ---
> > > > >  app/test-bbdev/Makefile        | 4 ++++
> > > > >  doc/guides/tools/testbbdev.rst | 7 +++++++
> > > > >  2 files changed, 11 insertions(+)
> > > > >
> > > > > diff --git a/app/test-bbdev/Makefile b/app/test-bbdev/Makefile
> > > > > index 6da0c8e..26c9a4b 100644
> > > > > --- a/app/test-bbdev/Makefile
> > > > > +++ b/app/test-bbdev/Makefile
> > > > > @@ -22,4 +22,8 @@ SRCS-$(CONFIG_RTE_TEST_BBDEV) +=
> > > > test_bbdev_vector.c
> > > > >
> > > > >  LDLIBS += -lm
> > > > >
> > > > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW),y)
> > > > > +LDLIBS += -lrte_pmd_bbdev_turbo_sw endif
> > > >
> > > > This is already done in mk/rte.app.mk, so it should not be needed.
> > > >
> > >
> > > We need this here when DPDK is built as dynamic library.
> > > In rte.app.mk lrte_pmd_bbdev_turbo_sw is added to LDLIBS when
> > > CONFIG_RTE_BUILD_SHARED_LIB is not set.
> >
> > In that case, you need to use the EAL option "-d" with  the .so library.
> >
> > ./testbbdev -d build/lib/librte_pmd_bbdev_turbo_sw.so --vdev="turbo_sw"
> 
> I thought it is fine as long as other test applications works in that way, e.g. test-
> crypto-perf, test-pmd
> 
> > Btw, now that I have seen the name of the vdev, I think you should
> > rename to "baseband_turbo_sw".
> > Also, NULL PMD should be renamed to "baseband_null".
> 
> Ok, we will deliver such changes in patches for next release. Are you ok with
> that?

I think this change should not take a long time. The sooner we do it, the better,
as there might be more people using this in the future.
I can send the patch for you, so you can focus on other changes, and then you can see if it is fine for you.

Thanks,
Pablo

> 
> 
> Best regards,
> Kamil