[dpdk-dev] [PATCH v9 3/5] test: add unit tests for latencystats library

Pattan, Reshma reshma.pattan at intel.com
Wed Aug 1 00:20:24 CEST 2018


Hi,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Tuesday, July 31, 2018 6:06 PM
> To: Pattan, Reshma <reshma.pattan at intel.com>; Somarowthu, Naga SureshX
> <naga.sureshx.somarowthu at intel.com>
> Cc: dev at dpdk.org; Burakov, Anatoly <anatoly.burakov at intel.com>;
> Parthasarathy, JananeeX M <jananeex.m.parthasarathy at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v9 3/5] test: add unit tests for latencystats
> library
> 
> 31/07/2018 18:40, Reshma Pattan:
> > From: Naga Suresh Somarowthu <naga.sureshx.somarowthu at intel.com>
> >
> > Unit Test Cases added for latencystats library.
> >
> > Signed-off-by: Naga Suresh Somarowthu
> <naga.sureshx.somarowthu at intel.com>
> > Reviewed-by: Reshma Pattan <reshma.pattan at intel.com>
> > ---
> 
> Compilation error with clang:
> 
> > +	struct rte_metric_name names[NUM_STATS] = { 0 };
> 
> test_latencystats.c:73:46: fatal error:
> suggest braces around initialization of subobject [-Wmissing-braces]
> 
> > +	struct rte_metric_name wrongnames[NUM_STATS - 2] = { 0 };
> 
> Usually, it is recommended to use memset for initializations of structs.
> 

Fixed in v10 .

Thanks,
Reshma



More information about the dev mailing list