[dpdk-dev] [PATCH] ethdev: decrease log level for successful API

Kevin Traynor ktraynor at redhat.com
Thu Aug 2 20:39:04 CEST 2018


subject prefix not updated - will resend as [PATCH v2]

On 08/02/2018 07:33 PM, Kevin Traynor wrote:
> Change log level of messages from ERR to INFO where
> the post condition of the API is success, but no action
> was actually needed as the condition already existed.
> e.g. calling rte_eth_dev_start() for a device that is
> already started.
> 
> Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic")
> 
> Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
> ---
>  lib/librte_ethdev/rte_ethdev.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index c7ab157..4c32025 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -797,5 +797,5 @@ struct rte_eth_dev *
>  
>  	if (dev->data->rx_queue_state[rx_queue_id] != RTE_ETH_QUEUE_STATE_STOPPED) {
> -		RTE_ETHDEV_LOG(ERR,
> +		RTE_ETHDEV_LOG(INFO,
>  			"Queue %"PRIu16" of device with port_id=%"PRIu16" already started\n",
>  			rx_queue_id, port_id);
> @@ -824,5 +824,5 @@ struct rte_eth_dev *
>  
>  	if (dev->data->rx_queue_state[rx_queue_id] == RTE_ETH_QUEUE_STATE_STOPPED) {
> -		RTE_ETHDEV_LOG(ERR,
> +		RTE_ETHDEV_LOG(INFO,
>  			"Queue %"PRIu16" of device with port_id=%"PRIu16" already stopped\n",
>  			rx_queue_id, port_id);
> @@ -857,5 +857,5 @@ struct rte_eth_dev *
>  
>  	if (dev->data->tx_queue_state[tx_queue_id] != RTE_ETH_QUEUE_STATE_STOPPED) {
> -		RTE_ETHDEV_LOG(ERR,
> +		RTE_ETHDEV_LOG(INFO,
>  			"Queue %"PRIu16" of device with port_id=%"PRIu16" already started\n",
>  			tx_queue_id, port_id);
> @@ -882,5 +882,5 @@ struct rte_eth_dev *
>  
>  	if (dev->data->tx_queue_state[tx_queue_id] == RTE_ETH_QUEUE_STATE_STOPPED) {
> -		RTE_ETHDEV_LOG(ERR,
> +		RTE_ETHDEV_LOG(INFO,
>  			"Queue %"PRIu16" of device with port_id=%"PRIu16" already stopped\n",
>  			tx_queue_id, port_id);
> @@ -1287,5 +1287,5 @@ struct rte_eth_dev *
>  
>  	if (dev->data->dev_started != 0) {
> -		RTE_ETHDEV_LOG(ERR,
> +		RTE_ETHDEV_LOG(INFO,
>  			"Device with port_id=%"PRIu16" already started\n",
>  			port_id);
> @@ -1319,5 +1319,5 @@ struct rte_eth_dev *
>  
>  	if (dev->data->dev_started == 0) {
> -		RTE_ETHDEV_LOG(ERR,
> +		RTE_ETHDEV_LOG(INFO,
>  			"Device with port_id=%"PRIu16" already stopped\n",
>  			port_id);
> 



More information about the dev mailing list