[dpdk-dev] [PATCH] devtools: fix symbol check for dash
Thomas Monjalon
thomas at monjalon.net
Sun Aug 5 11:38:47 CEST 2018
The script check-symbol-change.sh was not running when
/bin/sh redirects to dash.
Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
Cc: nhorman at tuxdriver.com
Reported-by: Stephen Hemminger <stephen at networkplumber.org>
Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
---
devtools/check-symbol-change.sh | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 40b72073a..daaf45e14 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -4,8 +4,8 @@
build_map_changes()
{
- local fname=$1
- local mapdb=$2
+ local fname="$1"
+ local mapdb="$2"
cat "$fname" | awk '
# Initialize our variables
@@ -80,7 +80,7 @@ build_map_changes()
check_for_rule_violations()
{
- local mapdb=$1
+ local mapdb="$1"
local mname
local symname
local secname
@@ -89,10 +89,10 @@ check_for_rule_violations()
while read mname symname secname ar
do
- if [ "$ar" == "add" ]
+ if [ "$ar" = "add" ]
then
- if [ "$secname" == "unknown" ]
+ if [ "$secname" = "unknown" ]
then
# Just inform the user of this occurrence, but
# don't flag it as an error
--
2.17.1
More information about the dev
mailing list